Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMI-244 Fixed CBRA report issues #2375

Merged
merged 1 commit into from
Dec 31, 2024
Merged

MMI-244 Fixed CBRA report issues #2375

merged 1 commit into from
Dec 31, 2024

Conversation

laidaoyu
Copy link
Collaborator

  • fixed the time zone issues that the publish on time in db has time zone info, updated the view to convert it to local time
  • updated staff summary time to show in hh:mm:ss format

@laidaoyu
MMI-244 Fixed CBRA report issues
6bc7ec9 
- fixed the time zone issues that the publish on time
in db has time zone info, updated the view to convert it
to local time
- updated staff summary time to show in hh:mm:ss format
@laidaoyu laidaoyu self-assigned this Dec 30, 2024
@Fosol Fosol added bug Something isn't working editor labels Dec 30, 2024
Fosol
Fosol reviewed Dec 30, 2024
View reviewed changes
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/dal/Migrations/TNOContextModelSnapshot.cs Show resolved Hide resolved
libs/net/entities/CBRAReportStaffSummary.cs Show resolved Hide resolved
Fosol
Fosol approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is actually correct when comparing to other entities that have been mapped. It looks like perhaps it was not correctly generated in your previous migration. I'm not certain why, but most likely an order of events issue.

@laidaoyu laidaoyu merged commit c491b57 into dev Dec 31, 2024
5 checks passed
@laidaoyu laidaoyu deleted the MMI-244 branch January 1, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

@JacobWang-bc JacobWang-bc Awaiting requested review from JacobWang-bc

@nehalaggarwal-bcgov nehalaggarwal-bcgov Awaiting requested review from nehalaggarwal-bcgov

Assignees

@laidaoyu laidaoyu

Labels
bug Something isn't working editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laidaoyu @Fosol